Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blurry pdf player rendering for all viewport sizes #6182

Merged
merged 3 commits into from
Oct 13, 2024

Conversation

dulli
Copy link
Contributor

@dulli dulli commented Oct 9, 2024

As asked for in #4768, I finally found the time to pull out the first of the PDF player improvements into its own pull request. Details below are copied from that PR. The rest will follow later on.

Changes

  • Improved the determination of the scale parameter to ensure non-blurry PDF rendering on both mobile and desktop viewports.

Issues

  • The blurry PDFs on high DPI displays were mentioned in Books (pdf) jellyfin-android#977 and allegedly fixed, but this introduced blurriness (for at least some?) PDFs on low DPI displays (i.e. desktop monitors). Now it shouldn't be blurry for both.

@dulli dulli requested a review from a team as a code owner October 9, 2024 18:17
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint doesn't pass. Please fix all ESLint issues.

src/plugins/pdfPlayer/plugin.js Outdated Show resolved Hide resolved
dulli and others added 2 commits October 9, 2024 20:23
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link

sonarcloud bot commented Oct 11, 2024

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 3ee3a4d870f6ccbadac7d18101a80a74c26ade3f
Status ✅ Deployed!
Preview URL https://004b1a55.jellyfin-web.pages.dev
Type 🔀 Preview

@thornbill thornbill merged commit 7e4921f into jellyfin:master Oct 13, 2024
12 checks passed
@viown viown mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants